Skip to content

GLASGOW | May-2025 | Taras Mykytiuk | Module-Data-Groups | Sprint_3 | Quote_Generator #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

GLASGOW | May-2025 | Taras Mykytiuk | Module-Data-Groups | Sprint_3 | Quote_Generator #615

wants to merge 2 commits into from
+36 −14

Conversation

TarasMykytiuk
Copy link

@TarasMykytiuk TarasMykytiuk commented Jul 15, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.
Changed files: quotes.js and index.html.
Web page now has random quotes, that can be changed by pressing button.

Questions

Ask any questions you have for your reviewer.

@TarasMykytiuk TarasMykytiuk added the Needs Review Participant to add when requesting review label Jul 15, 2025
@LonMcGregor LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jul 17, 2025
LonMcGregor
LonMcGregor reviewed Jul 17, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your quotes implementation works well - but can you think of a way to get it to generate a random quote when the page first loads? Right now it just shows a "hello" message when your first load the page.

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 17, 2025
@TarasMykytiuk
Copy link
Author

Thanks for review. Now quote generated when page fully loaded first time.

@TarasMykytiuk TarasMykytiuk added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Needs Review Participant to add when requesting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TarasMykytiuk @LonMcGregor